We're updating the issue view to help you get more done. 

Refactor SubQueryFindingExpressionTreeVisitor to be a PreprocessingExpressionTreeVisitor that also detects VB string comparisons

Description

  • Rename the visitor and the test fixture.

  • Write a unit test that passes an Expression.GreaterThan (Expression.Call (Microsoft.VisualBasic.CompilerServices.Operators.CompareString, left, right, Expression.Constant (true))) to the visitor. The result should be a VBStringComparisonExpression whose comparison member is BinaryExpression.GreaterThan (left, right) and whose TextCompare member is true.

  • Implement that functionality in the visitor by overriding VisitBinaryExpression and checking whether the left side is a MethodCallExpression to above method. Compare by full names, do not add a reference to Microsoft.VisualBasic.dll to the Data.Linq project. (A reference in the unit test is okay.)

  • Enable Remotion.Data.IntegrationTests.VB.Linq.LinqSamples101.Parsing.WhereTest.Test_01. Check that the ToString representation is that of a VBCompareStringExpression.

Status

Assignee

User

Reporter

Fabian Schmied

Components

Fix versions

Priority

Normal
Configure