We're updating the issue view to help you get more done. 

Support for Roslyn's Microsoft.VisualBasic.CompilerServices.EmbededOperators

Description

Roslyn VB compiler (at least in VS2017 Update 3 Preview 6.0) uses Microsoft.VisualBasic.CompilerServices.EmbededOperators for string comparison. The only difference is a class name.

Activity

Show:
Michael Ketting
September 20, 2017, 2:38 PM

Hi, that's cool! Thanks for that one

If you run dotnet new xunit in an empty folder, the .csproj looks very similar:

Ah, there it is. I completely missed that Test.Sdk line. Probably need to have my eyes checked...

So, basically, everyone with an existing solution is stuck until they do a manual upgrade of their test dependencies. That's not great. For the time being making an EagerFetching release to match re-linq is okay if there's no better solution by MS, but in the long term I really want to just depend on SemVer and NuGet to solve this. I'll update the github issue but would like to wait a bit until there is a respone from MS (or silence) before I do the EagerFetch update. If that work's for your release plan?

User known
October 20, 2017, 5:41 PM

Are you going to be able to make a synchronized release soon?

Michael Ketting
October 22, 2017, 2:07 PM

Has it already been a month? So, there hasn't really been anything helpful posted by the MSBuild guys on Github, which is unfortunate.

I can do a release next week. There's also a comptely different alternative: as a build-target file to the NHibernate nuget package an simply override the
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
from there (https://docs.microsoft.com/en-us/nuget/create-packages/creating-a-package#including-msbuild-props-and-targets-in-a-package) I could also add them to the EagerFetching package but I'm a bit reluctant due to the more global impact.

Michael Ketting
November 9, 2017, 8:34 PM

Okay, the pre-release of Eager Fetching is no live, too. (https://www.re-motion.org/jira/browse/RMLNQFETCH-22)

User known
November 10, 2017, 4:31 PM

In NHibernate, I already had the alpha version of Remotion.Linq in a pull request (#696) With the AutoGenerateBindingRedirects and GenerateBindingRedirectsOutputType set in the test projects.

We were waiting for a full release of Remotion.Linq and Remotion.Linq.EagerFetching v2.2.0 for the next released version of NHibernate. Don't want to include prerelease versions of dependencies, and need synchronized versions because that would minimize the hassle for down-stream projects that depend on NHibernate.

Assignee

Michael Ketting

Reporter

User known

Labels

None

Time tracking

0m

Components

Fix versions

Priority

Normal
Configure